Code

View refactorings#8

Code

Open

jkraemer wants to merge 17 commits intoharu:masterharu/redmine_code_review:masterfrom planio-gmbh:view-refactoringsplanio-gmbh/redmine_code_review:view-refactoringsCopy head branch name to clipboard

+235-251

Commits

Commits on Mar 12, 2018

• removes uses of raw

  jkraemer

  committed
  13c0404

  Copy full SHA for 13c0404

• removes unnecessary html escaping, it's always done automatically by Rails

  jkraemer

  committed
  1031d88

  Copy full SHA for 1031d88

• remove unnecessary usage of raw

  jkraemer

  committed
  e5a5b00

  Copy full SHA for e5a5b00

• extract helper method

  jkraemer

  committed
  a51fa15

  Copy full SHA for a51fa15

• refactor progress_for_changeset helper to use tag helpers

  Show description for 9f1491d
  jkraemer

  committed
  9f1491d

  Copy full SHA for 9f1491d

• refactor show_assignments helper and update_diff_view

  Show description for 75d5fa6
  jkraemer

  committed
  75d5fa6

  Copy full SHA for 75d5fa6

• replaces raw with sanitize

  Show description for 29841bf
  jkraemer

  committed
  29841bf

  Copy full SHA for 29841bf

• adds url argument to popupReview

  jkraemer

  committed
  7d3178a

  Copy full SHA for 7d3178a

• use j helper instead of manual gsub

  jkraemer

  committed
  e81074a

  Copy full SHA for e81074a

• use the show_assignments helper in change_revision_view as well

  jkraemer

  committed
  9fa3df2

  Copy full SHA for 9fa3df2

• remove unnecessary controller and requrest (sic) context values

  jkraemer

  committed
  4de5dda

  Copy full SHA for 4de5dda

• javascript escaping, parameters / params fix

  jkraemer

  committed
  157aed8

  Copy full SHA for 157aed8

• extract partial for diff view changing

  jkraemer

  committed
  0459edf

  Copy full SHA for 0459edf

• moves the big body_bottom conditional to ruby code.

  jkraemer

  committed
  216a176

  Copy full SHA for 216a176

• if only interested in the first changeset, we only need to ask for 1

  jkraemer

  committed
  a030dd2

  Copy full SHA for a030dd2

• readability, reduce number of variables

  jkraemer

  committed
  f387740

  Copy full SHA for f387740

• bugfixes

  jkraemer

  committed
  40143ef

  Copy full SHA for 40143ef