loading modal #10
Open
loading modal #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabeabrams
requested changes
Jul 1, 2024
src/components/Modal/index.tsx
Outdated
| @@ -15,6 +15,7 @@ import ReactDOM from 'react-dom'; | |||
|
|
|||
| // Import other components | |||
| import waitMs from '../../helpers/waitMs'; | |||
There was a problem hiding this comment.
Could you move this import to the right place? I think this issue was before you started, but let's fix it
src/components/Modal/index.tsx
Outdated
| @@ -495,7 +509,7 @@ const Modal: React.FC<ModalProps> = (props) => { | |||
| {title} | |||
| </h5> | |||
|
|
|||
| {(onClose && !dontShowXButton) && ( | |||
| {(onClose && !dontShowXButton && !(isLoading && !isLoadingCancelable)) && ( | |||
There was a problem hiding this comment.
Let's put this logic outside jsx and describe what's happening here, now that it's getting so complex
| {isLoading ? ( | ||
| <> | ||
| <LoadingSpinner /> | ||
| <span className="sr-only">Content loading</span> |
There was a problem hiding this comment.
If the programmer wants to create their own loading interface, let them. I think this should only be shown if children is undefined, null, an empty array, or falsy in some other way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.