installer: add role to specify the capability of node #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when a machine is created with we should revisit this workflow as well. |
Vicente-Cheng
force-pushed
the
wip-witness-support
branch
from
a1a65c4 to
9c0ba79
Compare
Hi @ibrokethecloud, I revisited this flow and updated it with the following scenario
Please help to recheck for it. |
bk201
reviewed
Dec 7, 2023
Vicente-Cheng
force-pushed
the
wip-witness-support
branch
from
9c0ba79 to
81bb31b
Compare
Now support `default` or `etcd` role. - default means the master node (control-plane, etcd, master) - etcd means the etcd node (etcd) NOTE: this only supports with join mode because the first node needs to be the master node. Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
wip-witness-support
branch
from
81bb31b to
e4ef88a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Support specify the node role
Solution:
Add
install.roleto choose the wanted role.Related Issue:
harvester/harvester#3266
Test plan:
Please check with harvester/harvester#4781