Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove mkinitrd and fix docker create #757

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Vicente-Cheng
Copy link
Contributor

Problem:
There were some build issues when we bumped the sle-micro 5.5.

Solution:
Use the correct command to build iso successfully.

Related Issue:
harvester/harvester#6027

Test plan:
TBD

@Vicente-Cheng Vicente-Cheng requested review from tserong and bk201 June 18, 2024 05:44
@Vicente-Cheng Vicente-Cheng marked this pull request as ready for review June 18, 2024 10:36
Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question.

scripts/package-harvester-os Outdated Show resolved Hide resolved
    - use `dracut -f --regenerate-all` to replace mkinitrd because
      mkinitrd is deprecated
    - docker create now need command to run

Signed-off-by: Vicente Cheng <[email protected]>
@Vicente-Cheng Vicente-Cheng merged commit 1e7572e into harvester:master Jun 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants