build: Add LOCAL_{ADDONS,HARVESTER}_SRC arguments #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/scripts/build` clones the harvester repo to "../harvester", but `/scripts/build-bundle` was using "/tmp/harvester". I've updated the latter to match the former, and also tweaked some of the messages slightly. Signed-off-by: Tim Serong <[email protected]>
This makes it really easy to run `make` from the installer repository and get an ISO built including modifications in a local harvester or addons repository. Prior to this, you'd have to manually edit Dockerfile.dapper to add a bind mount pointing to your other local source. Signed-off-by: Tim Serong <[email protected]>
bk201
approved these changes
Jul 10, 2024
Vicente-Cheng
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It's currently annoying to build ISO images from the harvester-installer repo when you want to also include changes from a local harvester and/or addons repo. You have to manually edit
Dockerfile.dapperand tweakDAPPER_RUN_ARGSto add something like-v /path/to/local/harvester/repo:/go/src/github.com/harvester/harvester.Solution:
I've added
LOCAL_HARVESTER_SRCandLOCAL_ADDONS_SRCenvironment variables to the build, which, if set, will automatically inject the correct-v /path/to/local/harvester/repoparameters, so now you can do this:I've also done a little minor rewording and made the harvester repo cloning in
scripts/build-bundleconsistent with what's done inscripts/build.Related Issue:
N/A
Test plan:
N/A