Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change order of interface startup #868

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ibrokethecloud
Copy link
Contributor

@ibrokethecloud ibrokethecloud commented Oct 15, 2024

Problem:

PR changes the order of nic startup to avoid nic renaming conflicts

Solution:

Related Issue:
harvester/harvester#6808
Test plan:

@ibrokethecloud ibrokethecloud merged commit f8a05d7 into harvester:master Oct 16, 2024
7 checks passed
@ibrokethecloud
Copy link
Contributor Author

@Mergifyio backport v1.4

Copy link

mergify bot commented Oct 16, 2024

backport v1.4

✅ Backports have been created

@ibrokethecloud
Copy link
Contributor Author

@Mergifyio backport v1.3

Copy link

mergify bot commented Oct 17, 2024

backport v1.3

✅ Backports have been created

@w13915984028
Copy link
Member

@ibrokethecloud @bk201

Do we have related upgrade processing? thanks.

@w13915984028
Copy link
Member

Confirmed in the upgraded cluster, the file also has the new content.

sudo -i cat /system/oem/90_network.yaml
...
  network:
    - name: Bring up interfaces
      commands:
      - |
        for i in /sys/class/net/{eth*,en*,ib*}; do
          [ -e $i ] || continue
          ip link set $(basename $i) up;

@bk201
Copy link
Member

bk201 commented Nov 20, 2024

yeah it's packaged in the squashfs and should be updated after a OS upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants