Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DHCP fails with a VLAN ID #878

Closed
wants to merge 1 commit into from

Conversation

bk201
Copy link
Member

@bk201 bk201 commented Nov 6, 2024

Problem:

Management interface with a VLAN ID fails to do DHCP configuration in the interactive installation. The testing traffic is sent without a VLAN ID.

Solution:

We should send the traffic via the mgmt-br.<vlan_id> interface.

Related Issue:

Test plan:

  • Boot ISO
  • make sure not DHCPD in vlan1 or non-vlan network.
  • When configuring the management interface, select a VLAN ID and use DHCP protocol.

@w13915984028
Copy link
Member

Thanks @bk201 for the quick validation, we merged this PR together with #879.

Copy link

mergify bot commented Nov 7, 2024

This pull request is now in conflict. Could you fix it @bk201? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants