feat: make curl progress bar correctly shows on the gui #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Yu <[email protected]>
Yu-Jack
commented
Nov 13, 2024
| for scanner.Scan() { | ||
| printToPanel(g, scanner.Text(), upgradePanel) | ||
| } | ||
| scanner = bufio.NewScanner(stderr) | ||
| scanner.Split(bufio.ScanLines) |
There was a problem hiding this comment.
BTW, when using bufio.NewScanner, the bufio.ScanLines is already split function by default. We don't need to set it up again.
Signed-off-by: Jack Yu <[email protected]>
tserong
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
LGTM (untested). This should also help me with harvester/harvester#5095 :-)
bk201
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When downloading ISO, the progress bar doesn't show well. The reason is that curl uses
\rto overwrite and print the progress bar. And the console.log in/oem/installis not aligned.Solution:
We should consider the
\rcharacter as well when scanning. And add a tag to switch different printers to print the messages.Related Issue:
harvester/harvester#5990
Test plan:
Install it with PXE, and check progress bar should display correctly.
Version 1
demo.mov
Console log in
/oem/install/console.logAfter
Version 2
Same as Version 1, but I use
"Total Spent Left Speed"as flag to trigger different printers. Then, we don't have duplicated header in/oem/install/console.log. But ... we still need theendcurlto change back to original printer.Version 3 (Recommended Way)
Don't use
\rto print the curl progress bar, just use\n. It will look likeconsole.login Version 1. But, if user's network bandwidth is not well, the log file and console would be large.demo-01.mov