-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rke2 network configuration to installer #886
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -202,6 +202,10 @@ resources: | |
enabled: true | ||
kube-vip-cloud-provider: | ||
enabled: true | ||
promote: | ||
clusterPodCIDR: {{ or .ClusterPodCIDR "10.52.0.0/16" }} | ||
clusterServiceCIDR: {{ or .ClusterServiceCIDR "10.53.0.0/16" }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When users customize/default those 3 fields, the value will be writen to If a user tries to change the managedchart on the fly, the result will be unexpected. btw, do you have a document PR to for those installation configuration options. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point on validation webhook. I don't see why not. I'll create a new issue for it. The document PR is still WIP. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created harvester/harvester#7196 to track validating webhook implementation. |
||
clusterDNS: {{ or .ClusterDNS "10.53.0.10" }} | ||
- apiVersion: management.cattle.io/v3 | ||
kind: ManagedChart | ||
metadata: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
RKE2
better thanpromote
?we also have another requirement: customize the RKE2 CNI, some one prefers
Calico
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial thought is to communicate that, within the
ManagedChart
, these settings are only used by the promotion controller, instead of a general mechanism to override RKE2, per harvester/harvester#7156. My current preference leans towards keeping it aspromote
. LMKWYT.Re: CNI, can we work on it as a separate issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, customized CNI will be in another issue & PR, which needs some investigation.
promotion
is also good.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom CNI enhancement request added at harvester/harvester#7197.