feat: add VIP mac address input panel #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Sim <[email protected]>
Signed-off-by: Ivan Sim <[email protected]>
Signed-off-by: Ivan Sim <[email protected]>
ihcsim
changed the title
|
@w13915984028 let me know what you think of this approach. |
bk201
requested review from
mingshuoqiu
and removed request for
ibrokethecloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There is a parity gap between the VIP configuration of the ISO installation and the automatic installation modes. In the automatic installation mode, user can specify the VIP MAC and static IP addresses over DHCP. This allows user to use a static IP address as the cluster's VIP. This option isn't available in the ISO installation mode.
Solution:
This PR updates the VIP configuration page of the installation console with a new
MAC Addressfield, to allow user to specify the VIP's MAC address in DHCP mode. The installer uses this MAC address to request for the specific static IP address over DHCP. If this field is left blank, the installer falls back to the current behaviour of determining the VIP and MAC address.On the VIP page, the subsequent input panels that will be shown are based on the method selected by the user:
Choosing
DHCPreveals both theMAC AddressandVIPinput panels:Choosing
Staticreveals only theVIPinput panel:Related Issue:
harvester/harvester#6960.
Test plan:
Test Case 1 - Request For Static VIP Address Using Custom MAC Address
Follow the instructions in this gist to add custom MAC/IP address bindings to the local kvm dnsmasq.
On the VIP page, input the custom MAC address (
32:34:1a:75:7f:64):192.168.122.39) from the DHCP serverComplete the rest of the installation setup to provision Harvester.
Provision a worker node to join the cluster targeting the static VIP address.
Test Case 2 - Let Installer Determine The VIP and MAC Address
On the VIP page, leave the MAC and VIP addresses blank.
Complete the rest of the installation setup to provision Harvester.
Provision a worker node to join the cluster via the static VIP address.