Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add agentTLSMode to rancherValues #975

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: add agentTLSMode to rancherValues #975

merged 1 commit into from
Feb 13, 2025

Conversation

FrankYang0529
Copy link
Member

Problem:
Rancher added new setting agent-tls-mode which breaks custom CA feature.

Solution:
Set the setting to system-store to fix the error.

Related Issue:
harvester/harvester#7453

Test plan:

  1. Build with harvester-installer to create an ISO.
  2. Start first node.
  3. Check whether value of agent-tls-mode setting is system-store.
  4. Setup ssl-certificates setting.
  5. Create second node to join first node without error.

@bk201 bk201 merged commit 59c9eb2 into harvester:master Feb 13, 2025
7 checks passed
@FrankYang0529 FrankYang0529 deleted the HARV-7453 branch February 13, 2025 03:15
This was referenced Feb 13, 2025
Merged
Merged
@FrankYang0529 FrankYang0529 mentioned this pull request Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@ibrokethecloud ibrokethecloud ibrokethecloud approved these changes

Assignees
No one assigned
Labels
backport-to/v1.4 backport-to/v1.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYang0529 @bk201 @ibrokethecloud