Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict the tls cipher #6

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: restrict the tls cipher #6

merged 1 commit into from
Jan 18, 2024

Conversation

Yu-Jack
Copy link
Contributor

@Yu-Jack Yu-Jack commented Jan 17, 2024

@Yu-Jack Yu-Jack self-assigned this Jan 17, 2024
@Yu-Jack Yu-Jack requested a review from bk201 January 17, 2024 01:53
@ibrokethecloud
Copy link

ibrokethecloud commented Jan 17, 2024 •
edited
Loading

in my original PR I had also specified MinVersion for TLS https://github.com/harvester/harvester/pull/4730/files#diff-6404509afd56daa425812290afd70394d934e45a776dcdb36087716a660c113aR167 do we want to keep that as well?

@Yu-Jack
Copy link
Contributor Author

Yu-Jack commented Jan 17, 2024

in my original PR I had also specified MinVersion for TLS https://github.com/harvester/harvester/pull/4730/files#diff-6404509afd56daa425812290afd70394d934e45a776dcdb36087716a660c113aR167 do we want to keep that as well?

Sounds good for me, let me add it.

bk201
bk201 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Jan 17, 2024
Merged
Merged
starbops
starbops approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ibrokethecloud
ibrokethecloud approved these changes Jan 18, 2024
View reviewed changes
Copy link

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@Yu-Jack Yu-Jack merged commit 8043200 into harvester:main Jan 18, 2024
2 checks passed
@Yu-Jack Yu-Jack deleted the fix-42 branch January 18, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrokethecloud ibrokethecloud ibrokethecloud approved these changes

@starbops starbops starbops approved these changes

@bk201 bk201 bk201 approved these changes

Assignees

@Yu-Jack Yu-Jack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yu-Jack @ibrokethecloud @bk201 @starbops