Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add visual tests to donations #922

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

NoamGaash
Copy link
Member

@NoamGaash NoamGaash commented Nov 16, 2024

Description

  1. adds a test for the donation modal
  2. adds a n aria attribute to the modal so it will be considered as a dialog

@NoamGaash NoamGaash changed the title test: add visual tests to donations (and add aria attribute) test: add visual tests to donations Nov 16, 2024
@NoamGaash
Copy link
Member Author

Hi @YaelChen , would you like to review the code? tell me if there's something I can make more clear or readable, or if anything requires adding more comment or something like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant