Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: public appeal page items #958

Merged
merged 2 commits into from
Dec 3, 2024
Merged

test: public appeal page items #958

merged 2 commits into from
Dec 3, 2024

Conversation

YaelChen
Copy link
Collaborator

@YaelChen YaelChen commented Dec 2, 2024

Description

I added a test to ensure the existence of all the "public appeal" headers.

@YaelChen YaelChen requested a review from ReallyLiri December 2, 2024 14:29
@YaelChen YaelChen requested a review from NoamGaash as a code owner December 2, 2024 14:29
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That's great.
After the English version will be translated, we'll be able to make a similar test for it as well 💪

@YaelChen
Copy link
Collaborator Author

YaelChen commented Dec 2, 2024 via email

@NoamGaash
Copy link
Member

there are some tickets regarding this page and/or translations, some of them are stale by now.
I'll close the irrelevant cards. I can't find any specific card for translating the public appear page, opening an issue would be a good idea

@YaelChen
Copy link
Collaborator Author

YaelChen commented Dec 3, 2024

This test is failing, and I wonder what do I miss (choosing params in "קיום נסיעות" and organize by date/hour).
image

It seems that no operating companies are on the list, although there are when I do it manually, locally, or on the web.

@YaelChen YaelChen closed this Dec 3, 2024
@YaelChen YaelChen reopened this Dec 3, 2024
@NoamGaash
Copy link
Member

In the "publish test results" I found the link to the report (we should fix the link in the comments, it's broken and I'm sorry about it. I'm not sure if we have an opened github issue for that or not):

Seems like it can't see "דן" in the dropdown - it didn't really load any option
image
In the network tab we can see some requests are cancelled:
image
it's because the request include the current date, which is not recorded in the HAR (network) file:
image

There are two ways to solve it

  1. use page.clock.setFixedTime to set a constant date for the application
  2. use urlComperator to declare that two urls with different dates are essentially the same and the response for gtfs_agencies/list?date_from=2024-12-01 can be used to respond requests to gtfs_agencies/list?date_from=2024-12-02

I think both approaches are valid, and open for other ideas.
You can see this line as a reference for the second approach

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is great!
Regarding the failing test - we should fix / skip it. It's not related to this pull request

@YaelChen YaelChen merged commit 5ea05c4 into main Dec 3, 2024
17 checks passed
@YaelChen YaelChen deleted the addTestForKolKore branch December 3, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants