-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: public appeal page items #958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! That's great.
After the English version will be translated, we'll be able to make a similar test for it as well 💪
Why isn't it translated yet btw? Is there a ticket for it?
בתאריך יום ב׳, 2 בדצמ׳ 2024, 17:01, מאת Noam Gaash <
***@***.***>:
… ***@***.**** approved this pull request.
Thank you! That's great.
After the English version will be translated, we'll be able to make a
similar test for it as well 💪
—
Reply to this email directly, view it on GitHub
<#958 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMFRPGCVEZ5LCI7NDMS4D6T2DRY33AVCNFSM6AAAAABS3RKLDSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZSHE2TGNBUGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
there are some tickets regarding this page and/or translations, some of them are stale by now. |
In the "publish test results" I found the link to the report (we should fix the link in the comments, it's broken and I'm sorry about it. I'm not sure if we have an opened github issue for that or not):
Seems like it can't see "דן" in the dropdown - it didn't really load any option There are two ways to solve it
I think both approaches are valid, and open for other ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is great!
Regarding the failing test - we should fix / skip it. It's not related to this pull request
Description
I added a test to ensure the existence of all the "public appeal" headers.