Linter fixes

funnel/models/__init__.py

@@ -1,6 +1,7 @@
 """Provide configuration for models and import all into a common `models` namespace."""
 
 # pyright: reportUnsupportedDunderAll=false
+# ruff: noqa: F811
 
 # The second half of this file is dynamically generated. Run `make initpy` to
 # regenerate. Since lazy_loader is opaque to static type checkers, there's an overriding

funnel/models/auth_client.py

@@ -531,9 +531,7 @@ def is_valid(self) -> bool:
         if self.validity == 0:
             return True  # This token is perpetually valid
         now = utcnow()
-        if self.created_at < now - timedelta(seconds=self.validity):
-            return False
-        return True
+        return not self.created_at < now - timedelta(seconds=self.validity)
 
     @classmethod
     def revoke_all_for(cls, account: Account) -> None:

funnel/transports/sms/send.py

@@ -108,9 +108,7 @@ def validate_exotel_token(token: str, to: str) -> bool:
 def okay_to_message_in_india_right_now() -> bool:
     """Report if it's currently within messaging hours in India (9 AM to 7PM IST)."""
     now = utcnow().astimezone(indian_timezone)
-    if now.hour >= DND_END_HOUR and now.hour < DND_START_HOUR:
-        return True
-    return False
+    return bool(now.hour >= DND_END_HOUR and now.hour < DND_START_HOUR)
 
 
 def send_via_exotel(

funnel/views/account_delete.py

@@ -52,9 +52,7 @@ def decorator(func: ValidatorFunc) -> ValidatorFunc:
 )
 def profile_is_protected(user: Account) -> bool:
     """Block deletion if the user has a protected account."""
-    if user.is_protected:
-        return False
-    return True
+    return not user.is_protected
 
 
 @delete_validator(
@@ -91,9 +89,7 @@ def profile_has_projects(user: Account) -> bool:
 )
 def user_owns_apps(user: Account) -> bool:
     """Fail if user is the owner of client apps."""
-    if user.clients:
-        return False
-    return True
+    return not user.clients
 
 
 # MARK: Delete validator view helper ---------------------------------------------------