Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add member-only visibility for project updates #1988

Merged
merged 27 commits into from
Mar 26, 2024
Merged

Add member-only visibility for project updates #1988

merged 27 commits into from
Mar 26, 2024

Conversation

jace
Copy link
Member

@jace jace commented Mar 12, 2024 •
edited
Loading

Implements #1967. Pending:

  • The model, form and view are all missing tests.
  • The update notification needs a data migration since role names have changed. This migration collapses two roles into one and therefore cannot be reversed.
  • The update notification needs to be retyped from Notification[Update, None] to Notification[Project, Update], requiring a more complicated data migration.

@jace jace requested review from vidya-ram and djamg March 12, 2024 09:46
jace and others added 15 commits March 12, 2024 17:48
@jace
Fix role check
dba34d3
@jace
Use ConditionalRole in Update; add new 'recipient' role alongside 're…
3ef9d6c 
…ader'
@jace
Test for 'reader' role granted to all in a public update
078a607
@jace
Fix separation between owner and admin in Account roles; better Updat…
727a5b8 
…e tests (partial)
@djamg
Added update notification template for update in project
1afda48
@jace
Participant update access test
df5c8c9
@jace
Redo Update 'recipient' role and prepare for 'account_follower' role
dfb0dda
@jace
Allow a notification to target roles based on document/fragment state
799f9f6 
Remove 'recipient' role from Update since it's no longer needed.
@jace
Migrate update notification and fix templates
b9c298c
@jace
Draft feature specs for project updates
67aeb12
@jace
Support rolled-up ProjectUpdateNotification; place members above part…
a237873 
…icipants in form
@jace
Merge branch 'main' into update-for-members
58c7128
@jace
Merge branch 'main' into update-for-members
02020ff
@jace
Replace all custom roles_for implementations with role_check or `…
aecc9b9 
…with_roles`
@zainabbawa
Add scenarios for posting public updates
8d41188
@CLAassistant
Copy link

CLAassistant commented Mar 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jace jace marked this pull request as ready for review March 26, 2024 06:09
vidya-ram
vidya-ram previously approved these changes Mar 26, 2024
View reviewed changes
@jace jace merged commit 53616e6 into main Mar 26, 2024
24 of 27 checks passed
@jace jace deleted the update-for-members branch March 26, 2024 11:31
jace added a commit that referenced this pull request Mar 26, 2024
@jace @djamg
@zainabbawa @pre-commit-ci
Add member-only visibility for project updates (#1988)
97fff41 
---------

Co-authored-by: Amogh M Aradhya <[email protected]>
Co-authored-by: Zainab Bawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jace jace mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djamg djamg djamg approved these changes

@vidya-ram vidya-ram vidya-ram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jace @CLAassistant @vidya-ram @djamg @zainabbawa