only pause GLSurfaceView if activity is moved to the background, and … #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not if it just loses focus
rampr
reviewed
Nov 11, 2024
| @@ -198,8 +197,7 @@ public void run() { | |||
| Cocos2dxGLSurfaceView.this.mCocos2dxRenderer.handleOnPause(); | |||
| } | |||
| }); | |||
| this.setRenderMode(RENDERMODE_WHEN_DIRTY); | |||
| // super.onPause(); | |||
| super.onPause(); | |||
There was a problem hiding this comment.
this change should be tested well. Has had issues in the past. Will this whole change work if commented out ?
There was a problem hiding this comment.
the rendering mode change works on pause and on stop, commenting this out will never pause the rendering thread, not sure about if we should have this or not as onStop and this will be called on every video or interstitial
There was a problem hiding this comment.
can you test the text rendering issues? then we can go live
thesayraj
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…not if it just loses focus