-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hip-551.md #1090
base: main
Are you sure you want to change the base?
Update hip-551.md #1090
Conversation
Add new updates to HIP-551 after implementation discussions
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HIP/hip-551.md
Outdated
|
||
## Rejected Ideas | ||
|
||
Conditional branching within batch transactions was rejected as it would introduce unnecessary complexity without significant value for the proposed use cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what conditional branching means. Please define that term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional branching in transaction chains determines the next transaction to execute (A or B) based on whether the previous transaction succeeded or failed.
Tx1 --Success--> TxA
Tx1 --Failure--> TxB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to the hip for clarification. Thanks @SimiHunjan !
|
||
## References | ||
All inner transactions must execute within the standard `transactionValidStart` and `transactionValidDuration` (typically 3 minutes) to ensure they remain valid during batch processing. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HIP should include a section on throttles and what the expectation is for the inner transactions and the batch transaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ty-swirldslabs may we get this resolved for @SimiHunjan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimiHunjan Added batch throttle section for clarity :)
Signed-off-by: Michael Garber <[email protected]>
Add new updates to HIP-551 after implementation discussions
Description:
Updated information and implementation description into HIP-551