Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hip-551.md #1090

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ty-swirldslabs
Copy link
Contributor

Add new updates to HIP-551 after implementation discussions

Description:
Updated information and implementation description into HIP-551

Add new updates to HIP-551 after implementation discussions
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 79e0cbb
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/67940824923ee00008b2c515
😎 Deploy Preview https://deploy-preview-1090--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mgarbs mgarbs requested a review from netopyr January 7, 2025 17:08
HIP/hip-551.md Outdated

## Rejected Ideas

Conditional branching within batch transactions was rejected as it would introduce unnecessary complexity without significant value for the proposed use cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what conditional branching means. Please define that term.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional branching in transaction chains determines the next transaction to execute (A or B) based on whether the previous transaction succeeded or failed.
Tx1 --Success--> TxA
Tx1 --Failure--> TxB

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the hip for clarification. Thanks @SimiHunjan !


## References
All inner transactions must execute within the standard `transactionValidStart` and `transactionValidDuration` (typically 3 minutes) to ensure they remain valid during batch processing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HIP should include a section on throttles and what the expectation is for the inner transactions and the batch transaction

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ty-swirldslabs may we get this resolved for @SimiHunjan?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimiHunjan Added batch throttle section for clarity :)

@mgarbs mgarbs requested a review from SimiHunjan January 23, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants