Updating DEV_MODE to be set to true. #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebadiere
added
the
Bug
Signed-off-by: ebadiere <[email protected]>
ebadiere
force-pushed
the
456-DEV_MODE-setting
branch
from
eb5f060
to
c32e986
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ebadiere
requested review from
nathanklick,
AlfredoG87,
Nana-EC and
georgi-l95
This was referenced Dec 5, 2023
georgi-l95
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Why is this change needed? Dev mode should be false, by default, as it's not the default behaviour of the relay. If dev mode is truly needed then, we need to change it in the local.json configuration OR in the test itself, by setting the process.env.DEV_MODE to true.
local.json configuration is used for all CI that run local-node as they used latest and greatest versions and features, while this change will alter the mainnet configuration, which should mimic the actual mainnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the DEV_MODE to true in the JSON RPC Relay in order to return the decoded contract revert reason.
Related issue(s):
Fixes #456