Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate account options starting in attached mode #462

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: generate account options starting in attached mode #462

merged 1 commit into from
Dec 6, 2023

Conversation

georgi-l95
Copy link
Collaborator

@georgi-l95 georgi-l95 commented Dec 6, 2023 •
edited
Loading

Description:
This PR fixes starting the generate-accounts option and debug option in attached mode.

Related issue(s):

Fixes #460

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@georgi-l95 georgi-l95 added Bug An error that causes the feature to behave differently than what was expected based on design. Limechain labels Dec 6, 2023
@georgi-l95 georgi-l95 self-assigned this Dec 6, 2023
@georgi-l95 georgi-l95 linked an issue Dec 6, 2023 that may be closed by this pull request
Trying to use generate-accounts option opens the TUI #460
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

natanasow
natanasow approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgi-l95 georgi-l95 merged commit 3f56e1a into main Dec 6, 2023
13 checks passed
@georgi-l95 georgi-l95 deleted the 460-trying-to-use-generate-accounts-option-opens-the-tui branch December 6, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isavov isavov isavov approved these changes

@natanasow natanasow natanasow approved these changes

@stefan-stefanooov stefan-stefanooov stefan-stefanooov approved these changes

@Ivo-Yankov Ivo-Yankov Ivo-Yankov approved these changes

@konstantinabl konstantinabl Awaiting requested review from konstantinabl konstantinabl is a code owner

Assignees

@georgi-l95 georgi-l95

Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Limechain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to use generate-accounts option opens the TUI
5 participants
@georgi-l95 @Ivo-Yankov @stefan-stefanooov @natanasow @isavov