Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose opcodes endpoint by default #638

Merged
merged 5 commits into from
Jun 12, 2024
Merged

feat: expose opcodes endpoint by default #638

merged 5 commits into from
Jun 12, 2024

Conversation

victor-yanev
Copy link
Contributor

@victor-yanev victor-yanev commented Jun 7, 2024 •
edited
Loading

Problem

As part of HIP-801, we need to change the mirror-node properties of the web3 module to enable the endpoint for the opcode logger which is disabled by default.

Solution

  • We need to set the hedera.mirror.web3.opcode.tracer.enabled=true in the application.yml file with custom properties for the mirror-node.
  • Change the docker configurations to override these values in the web3 module of mirror-node from the application.yml file
  • Add documentation for the overridden properties of the web3 module in the local-node

@victor-yanev victor-yanev added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk. Limechain labels Jun 7, 2024
@victor-yanev victor-yanev self-assigned this Jun 7, 2024
georgi-l95
georgi-l95 previously approved these changes Jun 7, 2024
View reviewed changes
@victor-yanev
Merge branch 'main' into 619-expose-opcodes-endpoint-by-default
a6f2da5 
# Conflicts:
#	test/unit/states/InitState.spec.ts
@victor-yanev victor-yanev linked an issue Jun 12, 2024 that may be closed by this pull request
Expose opcodes endpoint by default #647
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@victor-yanev victor-yanev merged commit 5cf9b33 into main Jun 12, 2024
12 checks passed
@victor-yanev victor-yanev deleted the 619-expose-opcodes-endpoint-by-default branch June 12, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgi-l95 georgi-l95 georgi-l95 approved these changes

@isavov isavov Awaiting requested review from isavov

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@konstantinabl konstantinabl Awaiting requested review from konstantinabl konstantinabl is a code owner

Assignees

@victor-yanev victor-yanev

Labels
Limechain New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P1 High priority issue, which must be completed in the milestone otherwise the release is at risk.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose opcodes endpoint by default
2 participants
@victor-yanev @georgi-l95