fix: local node not starting with tag command #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
georgi-l95
requested review from
isavov,
Ivo-Yankov,
natanasow,
konstantinabl and
victor-yanev
as code owners
georgi-l95
added
the
Bug
Signed-off-by: georgi-l95 <[email protected]>
isavov
previously approved these changes
Aug 6, 2024
Signed-off-by: georgi-l95 <[email protected]>
|
isavov
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where local-node throws an error on startup, if you try to load images using tag command. Problem comes from the recently changed docker hub policy and deployment of havaged images to the registry.
Because this images is not actually used, we removed the ability to change the default value using the CLI.
Also bumped the images and local-node version
Related issue(s):
Fixes #722
Notes for reviewer:
Checklist