Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: RestoreKey, feat: ButtonGroup #1463

Merged
merged 9 commits into from
Jan 21, 2025
Merged

refactor: RestoreKey, feat: ButtonGroup #1463

merged 9 commits into from
Jan 21, 2025

Conversation

icoxxx
Copy link
Contributor

@icoxxx icoxxx commented Jan 17, 2025

Description:

  • Refactor of RestoreKey page, each step of it is represented by an individual, self-contained component.
  • Replaced all @submit instances in the codebase with @submit.prevent. Removed e.preventDefault() in the handlers.
  • Created ButtonGroup reusable component

Related issue(s):
#1442

@icoxxx icoxxx self-assigned this Jan 17, 2025
@icoxxx icoxxx requested review from SvetBorislavov, yiliev0 and a team as code owners January 17, 2025 08:05
@icoxxx icoxxx linked an issue Jan 17, 2025 that may be closed by this pull request
FE Refactoring / Enhancement #1442
Closed
@icoxxx icoxxx requested a review from jbair06 January 17, 2025 08:05
@icoxxx icoxxx force-pushed the 1442-fe-refactoring-enhancement branch from 4e73456 to a260651 Compare January 17, 2025 09:13
@SvetBorislavov SvetBorislavov force-pushed the 1442-fe-refactoring-enhancement branch from a260651 to 3fae98a Compare January 20, 2025 09:46
SvetBorislavov
SvetBorislavov requested changes Jan 20, 2025
View reviewed changes
front-end/src/renderer/components/ui/ButtonGroup.vue Outdated Show resolved Hide resolved
front-end/src/renderer/pages/Settings/components/GeneralTab/components/NetworkSettings.vue Outdated Show resolved Hide resolved
front-end/src/renderer/pages/Settings/components/GeneralTab/components/NetworkSettings.vue Outdated Show resolved Hide resolved
front-end/src/renderer/pages/Settings/components/GeneralTab/components/NetworkSettings.vue Show resolved Hide resolved
front-end/src/renderer/pages/Settings/components/GeneralTab/components/NetworkSettings.vue Outdated Show resolved Hide resolved
front-end/src/renderer/pages/RestoreKey/components/RestoreStep.vue Show resolved Hide resolved
front-end/src/renderer/pages/RestoreKey/components/RestoreStep.vue Outdated Show resolved Hide resolved
front-end/src/renderer/pages/RestoreKey/RestoreKey.vue Outdated Show resolved Hide resolved
front-end/src/renderer/pages/RestoreKey/components/SaveStep.vue Outdated Show resolved Hide resolved
front-end/src/renderer/pages/RestoreKey/components/SaveStep.vue Show resolved Hide resolved
icoxxx added 9 commits January 21, 2025 11:17
@icoxxx
fix: form submission
3254b60 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
refactor: RestoreKey
b35722a 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
fix: variable type
a141873 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
feat: ButtonGroup component
34e62e0 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
refactor: AppearanceSettings
6b7ca59 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
fix: ButtonGroup data-testid
8e4feb3 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
fix: RestoreKey
fba8826 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
fix: handleFindEmptyIndex
d1e35da 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx
fix: RestoreKey types, imports
5b143e5 
Signed-off-by: Hristiyan <[email protected]>
@icoxxx icoxxx force-pushed the 1442-fe-refactoring-enhancement branch from 88444fd to 5b143e5 Compare January 21, 2025 09:17
@SvetBorislavov SvetBorislavov merged commit 10475ed into main Jan 21, 2025
15 checks passed
@SvetBorislavov SvetBorislavov deleted the 1442-fe-refactoring-enhancement branch January 21, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvetBorislavov SvetBorislavov SvetBorislavov approved these changes

@yiliev0 yiliev0 Awaiting requested review from yiliev0 yiliev0 is a code owner

@jbair06 jbair06 Awaiting requested review from jbair06 jbair06 is a code owner automatically assigned from hashgraph/transaction-tool

Assignees

@icoxxx icoxxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE Refactoring / Enhancement
2 participants
@icoxxx @SvetBorislavov