-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icu 14777 add more target tests #2594
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5fc9732
to
82a5bfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured the http methods would be the way to go for desktop tests.
Ran the tests locally. Pretty niceeeeeee.
curious to know if you considered sharing |
I have, right now our configs diverge enough where I didn't want to share it |
82a5bfe
to
97ded69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!! very excited for this, the move makes e2e test being first class citizen!! Thank you
Left some none blocking comments 😉
Ahh I made the assumption the key says |
ba1dc96
to
a7c2499
Compare
a7c2499
to
0b3d0ba
Compare
0b3d0ba
to
15a6ab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
15a6ab5
to
28772a4
Compare
28772a4
to
873cc9d
Compare
Description
Added some more target tests that utilize enos for e2e. I decided to setup much of the boundary bits needed for testing using HTTP requests. Open to discussion about this.
There's realistically 3 ways to interact with boundary for a lot of our test setups:
I tried the boundary CLI first but I didn't see much of a benefit using it over HTTP besides @moduli having already built out most of the commands. It also introduces more overhead having to spin up shells to execute the commands.
I tried using admin UI to setup tests which also has the huge benefit of having @moduli already built most of what we need and it worked well except for a few quirks:
I decided mainly to keep things separate between admin and desktop as well as to keep test setups much faster and to just build out the boundary HTTP client requests. It setups up quite fast and and is still straight forward to interact with.
I also updated the README into a shared one at the root.
How to Test
Run through the admin README to setup enos using enterprise boundary. At the e2e root folder, run
yarn desktop
.Checklist
[ ] I have added before and after screenshots for UI changes[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description[ ] My changes generate no new warnings