-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e test page selectors due to hds refactor #2610
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, ran fine against ent tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor @lisbet-alvarez ! Awesome work!!
I ran the CE edition as expected, without an issue.
I did encounter 1 failing test within ent which does not match with the one you reported within PR description.
Not sure if related to this PR, but leaving an screenshot here. If you think its not related, please let me know I will proceed to debug 😉
hm i don't think its related, those tests didn't fail for me at all. |
@lisbet-alvarez |
Description
Refactor test page selectors to accommodate changes made to app state messages.
Upgrade playwright to newest version in order to install newer browser versions since
popover
used in newer hds version isn't supported by firefox v124.Screenshots (if appropriate)
tests passing in ce
![image](https://private-user-images.githubusercontent.com/107949262/393028186-cbbb3d3c-e578-48aa-bfe1-ab7181c411c7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDg1ODcsIm5iZiI6MTczOTQ0ODI4NywicGF0aCI6Ii8xMDc5NDkyNjIvMzkzMDI4MTg2LWNiYmIzZDNjLWU1NzgtNDhhYS1iZmUxLWFiNzE4MWM0MTFjNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMjA0NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01ZDcwM2I4MjcyMWU4ODE1OTk4ZDkxN2FmMDZjOGY5MmJhMDc3NTA2ODBhZDA1M2Q4NDRlMWNmNjQ5NTNiOGYyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.3qXFhVOFLrslGVgd34hIj5Gk9Bqq4PkHKwuhqdm_ghg)
tests passing in ent, the tests failing are flaky (there's already a ticket for that)
![image](https://private-user-images.githubusercontent.com/107949262/393028572-70616d81-a5d5-4075-aaa7-e8591aa52b4a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDg1ODcsIm5iZiI6MTczOTQ0ODI4NywicGF0aCI6Ii8xMDc5NDkyNjIvMzkzMDI4NTcyLTcwNjE2ZDgxLWE1ZDUtNDA3NS1hYWE3LWU4NTkxYWE1MmI0YS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxMjA0NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMDU4MDQ2YWViYzI4MDZhNmZmYTJjMGM5ZjY0MzM2MGE1YjMzZjI2ZWJiZTE1YzQwNjI2MjdiNmY4YjE1MzA3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.v7lccgFeJ2rdHts4HJ29LjMM3tcRNfWXrVxKaKloffA)
How to Test
e2e-testing
folder to setup enos testing env.Checklist