Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test page selectors due to hds refactor #2610

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Dec 4, 2024

Description

Refactor test page selectors to accommodate changes made to app state messages.
Upgrade playwright to newest version in order to install newer browser versions since popover used in newer hds version isn't supported by firefox v124.

Screenshots (if appropriate)

tests passing in ce
image

tests passing in ent, the tests failing are flaky (there's already a ticket for that)
image

How to Test

  1. build boundary binary (using most recent ui commit in main)
  2. follow readme instructions in e2e-testing folder to setup enos testing env.
  3. run tests & validate only tests failing are in firefox & webkit browsers.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:11am
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:11am

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ran fine against ent tests!

Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor @lisbet-alvarez ! Awesome work!!

I ran the CE edition as expected, without an issue.

I did encounter 1 failing test within ent which does not match with the one you reported within PR description.
Not sure if related to this PR, but leaving an screenshot here. If you think its not related, please let me know I will proceed to debug 😉
Screenshot 2024-12-09 at 3 53 56 PM

@lisbet-alvarez
Copy link
Collaborator Author

lisbet-alvarez commented Dec 10, 2024

Nice refactor @lisbet-alvarez ! Awesome work!!

I ran the CE edition as expected, without an issue.

I did encounter 1 failing test within ent which does not match with the one you reported within PR description. Not sure if related to this PR, but leaving an screenshot here. If you think its not related, please let me know I will proceed to debug 😉 Screenshot 2024-12-09 at 3 53 56 PM

hm i don't think its related, those tests didn't fail for me at all.
thank you for testing as well!

@calcaide
Copy link
Collaborator

Nice refactor @lisbet-alvarez ! Awesome work!!
I ran the CE edition as expected, without an issue.
I did encounter 1 failing test within ent which does not match with the one you reported within PR description. Not sure if related to this PR, but leaving an screenshot here. If you think its not related, please let me know I will proceed to debug 😉 Screenshot 2024-12-09 at 3 53 56 PM

hm i don't think its related, those tests didn't fail for me at all. thank you for testing as well!

@lisbet-alvarez
Gotcha! I will review and debug that test 😉 Thanks for the feedback!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants