Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add showFilterGenerator to WorkerFilterGenerator comp #2669

Conversation

cameronperera
Copy link
Collaborator

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-16282

Description

This change makes it so we can determine if the "Show filter generator" is toggled on by default or not. When the generator is used in a longer form like creating a Vault credential store or storage bucket, we want to hide the generator. This keeps the form from being overly long. In places like the Worker Filter tab for Target for Vault credential store, we have a route dedicated to updating the worker filter where showing the generator by default makes more sense.

New Storage Bucket:

Screen.Recording.2025-01-28.at.5.32.51.PM.mov

New Vault credential store:

Screen.Recording.2025-01-28.at.5.34.00.PM.mov

Editing Vault credential store worker filter:

Screen.Recording.2025-01-28.at.5.34.41.PM.mov

Editing Target worker filter:

Screen.Recording.2025-01-28.at.5.35.01.PM.mov

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera added this to the 0.19.0 milestone Jan 28, 2025
@cameronperera cameronperera self-assigned this Jan 28, 2025
@cameronperera cameronperera requested a review from a team as a code owner January 28, 2025 23:56
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 11:56pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 11:56pm

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement!!

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lisbet-alvarez lisbet-alvarez merged commit ae1e6d2 into main Jan 29, 2025
13 checks passed
@lisbet-alvarez lisbet-alvarez deleted the ICU-16282-add-show-filter-generator-attribute-to-worker-filter-generator-component branch January 29, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants