fix: 🐛 reapply storage policy errors out after a failed delete

[lisbet-alvarez]

Description

When a delete fails on a session-recording, the isDeleted attribute is set to true but isDestroyed is set to false so when we try to use this.save on model it sends another DELETE request instead of a POST request for the reapply-storage-policy method. Solution was to rollbackAttributes after a failed DELETE.

Additionally, hide delete button when storage policy is retain "forever" on a session recording.

Screenshots (if appropriate)

BEFORE:

Screen.Recording.2025-01-31.at.5.45.52.PM.mov

AFTER:

Screen.Recording.2025-01-31.at.5.42.04.PM.mov

hide delete button when retain policy is "Forever"

Screen.Recording.2025-02-04.at.1.23.35.PM.mov

How to Test

Checklist

• I have added before and after screenshots for UI changes
• I have added JSON response output for API changes
• I have added steps to reproduce and test for bug fixes in the description
• I have commented on my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 4, 2025 9:59pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 4, 2025 9:59pm

[ZedLi]

Tested and works great, thanks for the fix!

[ZedLi]

Looks good, left a non blocking comment

[DhariniJeeva]

thanks for the fix, looks great!

[ZedLi]

Thanks for the fix!