Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 Read aliases test suite #2691

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

laurenolivia
Copy link
Collaborator

@laurenolivia laurenolivia commented Feb 13, 2025

Description

This PR:

  1. Refactors our read aliases test suite.
  2. Replaces instances of [data-test-toast-notification] .hds-alert__description with the ALERT_TOAST_BODY const from our test helpers file.
  3. Replaces instances of this.server.db with this.server.schema (ongoing).

🎟️ Jira ticket

Screenshots (if appropriate)

How to Test

Tests should pass ✅

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@laurenolivia laurenolivia requested a review from a team as a code owner February 13, 2025 17:40
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ❌ Failed (Inspect) Feb 13, 2025 5:42pm
boundary-ui-desktop ❌ Failed (Inspect) Feb 13, 2025 5:42pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant