Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null updates #78

Merged
merged 36 commits into from
May 31, 2020
Merged

Null updates #78

merged 36 commits into from
May 31, 2020

Conversation

jimlambrt
Copy link
Collaborator

  • add support updating fields to null in the db package
  • add support updating Scope fields to null the iam package

A separate PR will address the oplog package's support for updating fields to null.

Jim Lambert added 18 commits May 23, 2020 10:11
@jimlambrt jimlambrt requested a review from mgaffney May 25, 2020 13:59
@mgaffney
Copy link
Member

Can you merge master into this branch? I'm trying to run the tests but I'm getting a panic.

mgaffney
mgaffney requested changes May 28, 2020
View reviewed changes
@jimlambrt jimlambrt requested review from mgaffney and jefferai May 29, 2020 00:13
mgaffney
mgaffney requested changes May 29, 2020
View reviewed changes
Copy link
Member

@mgaffney mgaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things plus I think you missed comments I left in read_writer.go and read_writer_test.go. Can you take a look at those?

@jimlambrt jimlambrt requested a review from mgaffney May 29, 2020 18:42
mgaffney
mgaffney requested changes May 29, 2020
View reviewed changes
@jimlambrt jimlambrt requested a review from mgaffney May 29, 2020 20:15
mgaffney
mgaffney previously approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@mgaffney mgaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@jimlambrt
Copy link
Collaborator Author

thanks for your help. I still can't believe how quickly this PR grew in size. happy to see it almost ready to merge. there are a ton of things waiting for this to be merged.

@jimlambrt jimlambrt merged commit ef6edbd into master May 31, 2020
@jimlambrt jimlambrt deleted the jimlambrt/null-updates branch June 8, 2020 20:01
johanbrandhorst pushed a commit that referenced this pull request May 31, 2023
@louisruch
feat(ssh): Add support for ssh_private_key injection (#78)
0fbcf3d 
* feat(ssh-proxy): Add support for ssh_private_key injection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

@mgaffney mgaffney mgaffney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimlambrt @mgaffney @jefferai