Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cert.mdx #22214

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update cert.mdx #22214

wants to merge 2 commits into from

Conversation

johncooler
Copy link

@johncooler johncooler commented Mar 7, 2025

Description

-domain flag is required not only for server certificate creation

Testing & Reproduction steps

# create CA with DNS constraint
consul tls ca create -name-constraint -domain consul.local

# create server certificates respectively
consul tls cert create  -domain consul.local -ca consul.local-agent-ca.pem  -key consul.local-agent-ca-key.pem -server
consul tls cert create  -domain consul.local -ca consul.local-agent-ca.pem  -key consul.local-agent-ca-key.pem -server
consul tls cert create  -domain consul.local -ca consul.local-agent-ca.pem  -key consul.local-agent-ca-key.pem -server

# fails
consul tls cert create   -ca consul.local-agent-ca.pem  -key consul.local-agent-ca-key.pem -client

# works
consul tls cert create  -domain consul.local -ca consul.local-agent-ca.pem  -key consul.local-agent-ca-key.pem -client

Links

image

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@johncooler johncooler requested review from a team as code owners March 7, 2025 12:34
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Mar 7, 2025
@johncooler
Copy link
Author

I also see conditional problem with client certificate issuing

I can't use -node parameter to set different subdomain in SubjectAltName field
each client certificate have the same client.dc1.consul DNS name

If try to create such certificates through -server command parameter, CN field would match server certificates, I don't want it

Now I try to use cfssl utility with 2 intermediate certificates, I sure it would work

@johncooler
Copy link
Author

@tgross I had successful conversation with you before, so I hope you can help with that issue

@tgross
Copy link
Member

tgross commented Mar 7, 2025

Hi @johncooler! Thanks for the PR. There's a set of required reviewers for this repo, and just due to internal arrangement of teams I'm not in that list. 😀 It looks like this has been appropriately tagged for review, so I imagine they'll come along once they're available.

@johncooler
Copy link
Author

@tgross thanks a lot, let's be in touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants