Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: homepage feature flag #304

Closed
wants to merge 1 commit into from
Closed

Conversation

alexcarpenter
Copy link
Contributor

"Ready for Review" checklist

  • The Vercel preview link has been added to this PR's description
  • The Asana task has been added to this PR's description
  • This PR's link has been added to the "📐 Pull Request" field on the Asana task
  • This Vercel preview link has been added to the "🔍 Preview" field on the Asana task
  • The description template has been filled in below

Relevant links

What

Why

How

Testing

Anything else?

@alexcarpenter alexcarpenter requested a review from zchsh April 12, 2022 22:41
@alexcarpenter alexcarpenter deleted the ac.fix-homepage-flag branch April 12, 2022 22:42
@github-actions
Copy link

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load
/_proxied-dot-io/consul/docs 165.96 KB 297.02 KB
/_proxied-dot-io/consul/docs/[...page] 165.46 KB 296.52 KB

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 22.26 KB (🟢 -506 B) 153.32 KB
/_middleware 44.9 KB (🟡 +591 B) 175.96 KB
/swingset/[[...swingset]] 338.1 KB (🟡 +1.19 KB) 469.16 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

hashibot-web pushed a commit that referenced this pull request Apr 4, 2024
…ct-landing-page

Update HCP Consul to HCP Consul Dedicated in product landing page json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant