Fix the fact that some GCP env vars are immune to WithDisallowEnvVars #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgmiller
changed the title
| @@ -23,7 +23,6 @@ const ( | |||
| // TestGcpKeyIdAfterConfig will test the result of calling the wrapper's KeyId() | |||
| // after it's configured with various options | |||
| func TestGcpKeyIdAfterConfig(t *testing.T) { | |||
| t.Parallel() | |||
There was a problem hiding this comment.
This was removed as it didn't play nice with the new test case disabling env-vars
| } | ||
|
|
||
| func TestGcpCkmsSeal(t *testing.T) { | ||
| t.Setenv(EnvGcpCkmsWrapperProject, "") // Make sure at least one required value is not set. |
There was a problem hiding this comment.
This test worked correctly if it ran by itself but running them all together, if another test ran first and set the appropriate vars would fail as we wouldn't get the failure we expected.
jefferai
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.