Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Evan Phoenix <[email protected]>
  • Loading branch information
briancain and evanphx authored Mar 4, 2024
1 parent 3445071 commit 9d8f9df
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
4 changes: 1 addition & 3 deletions internal/commands/waypoint/actionconfig/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,5 @@ func listActionConfig(c *cmd.Command, args []string, opts *ListOpts) error {
}

respPayload := resp.GetPayload()
d := format.NewDisplayer(respPayload.ActionConfigs, format.Pretty, actionConfigFields)

return opts.Output.Display(d)
return opts.Output.Show(respPayload.ActionConfigs, format.Pretty)
}
3 changes: 1 addition & 2 deletions internal/commands/waypoint/actionconfig/read.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,5 @@ func readActionConfig(c *cmd.Command, args []string, opts *ReadOpts) error {
}

respPayload := resp.GetPayload()
d := format.NewDisplayer(respPayload.ActionConfig, format.Pretty, actionConfigFields)
return opts.Output.Display(d)
return opts.Output.Show(respPayload.ActionConfig, format.Pretty)
}
8 changes: 3 additions & 5 deletions internal/commands/waypoint/actionconfig/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ func NewCmdUpdate(ctx *cmd.Context) *cmd.Command {

cmd := &cmd.Command{
Name: "update",
ShortHelp: "Update a new action configuration.",
LongHelp: "Update a new action configuration to be used to launch an action with.",
ShortHelp: "Update a action configuration.",
LongHelp: "Update a action configuration to be used to launch an action with.",
RunF: func(c *cmd.Command, args []string) error {
return updateActionConfig(c, args, opts)
},
Expand Down Expand Up @@ -140,7 +140,5 @@ func updateActionConfig(c *cmd.Command, args []string, opts *UpdateOpts) error {
fmt.Fprintf(opts.IO.Err(), "Action config %q updated.", opts.Name)

respPayload := resp.GetPayload()
d := format.NewDisplayer(respPayload.ActionConfig, format.Pretty, actionConfigFields)

return opts.Output.Display(d)
return opts.Output.Show(respPayload.ActionConfig, format.Pretty)
}

0 comments on commit 9d8f9df

Please sign in to comment.