refactor: Eliminate variable field that's no longer required.

BREAKING CHANGE: The "type" field for Waypoint variable options is no longer required by the API. It is "output only" and need not be set by clients. Therefore, it can be removed from the input config file for variable options.

.changelog/174.txt

@@ -0,0 +1,3 @@
+```release-note:breaking-change
+waypoint: Remove type field from variable options config file.
+```

internal/commands/waypoint/internal/variable_options.go

@@ -24,15 +24,13 @@ func ParseVariableOptionsFile(path string) ([]*models.HashicorpCloudWaypointTFMo
 // # Example contents of a vars.hcl file
 //
 //	variable_option "string_variable" {
-//	  type = "string"
 //	  options = [
 //	    "a string value",
 //	  ]
 //	  user_editable = false
 //	}
 //
 //	variable_option "misc_variable" {
-//	  type = "string"
 //	  options = [
 //	    "another string value",
 //	  ]
@@ -53,7 +51,6 @@ func parseVariableOptions(filename string, input []byte) ([]*models.HashicorpClo
 		for _, v := range hc.VariableOptions {
 			variables = append(variables, &models.HashicorpCloudWaypointTFModuleVariable{
 				Name:         v.Name,
-				VariableType: v.Type,
 				Options:      v.Options,
 				UserEditable: v.UserEditable,
 			})
@@ -64,7 +61,6 @@ func parseVariableOptions(filename string, input []byte) ([]*models.HashicorpClo
 
 type hclVariableOption struct {
 	Name         string   `hcl:",label"`
-	Type         string   `hcl:"type"`
 	Options      []string `hcl:"options"`
 	UserEditable bool     `hcl:"user_editable,optional"`
 }

internal/commands/waypoint/internal/variable_options_test.go

@@ -18,7 +18,6 @@ func Test_VariableOptionsFileParse(t *testing.T) {
 
 		hcl := `
           variable_option "string_variable" {
-            type = "string"
             options = [
               "a string value",
             ]
@@ -30,7 +29,6 @@ func Test_VariableOptionsFileParse(t *testing.T) {
 		r.NoError(err)
 		r.Equal(1, len(variableInputs))
 		r.Equal("string_variable", variableInputs[0].Name)
-		r.Equal("string", variableInputs[0].VariableType)
 		r.Equal(false, variableInputs[0].UserEditable)
 	})
 
@@ -41,7 +39,6 @@ func Test_VariableOptionsFileParse(t *testing.T) {
 
 		hcl := `
           variable_option "string_variable" {
-            type = "string"
             options = [
               "a string value",
         		"another string value",
@@ -65,7 +62,6 @@ func Test_VariableOptionsFileParse(t *testing.T) {
 
 		hcl := `
 variable_option "string_variable" {
-  type = "string"
   options = [
     "a string value",
 		"another",
@@ -74,7 +70,6 @@ variable_option "string_variable" {
 }
 
 variable_option "misc_variable" {
-  type = "int"
   options = [
     8,
 		2,
@@ -92,7 +87,6 @@ variable_option "misc_variable" {
 
 		r.Equal("misc_variable", variableInputs[1].Name)
 		r.Equal(2, len(variableInputs[1].Options))
-		r.Equal("int", variableInputs[1].VariableType)
 		r.Equal(false, variableInputs[1].UserEditable)
 	})
 
@@ -102,12 +96,7 @@ variable_option "misc_variable" {
 		r := require.New(t)
 
 		hcl := `
-variable_option "" {
-  options = [
-    8,
-		2,
-  ]
-}
+variable_option "" {}
 `
 
 		_, err := parseVariableOptions("blah.hcl", []byte(hcl))