Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Codeowners for current cloud core platform #158

Closed
wants to merge 1 commit into from
Closed

Update Codeowners for current cloud core platform #158

wants to merge 1 commit into from

Conversation

jasonpilz
Copy link
Member

Changes proposed in this PR:

  • Updates ownership for current core platform team ownership

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@jasonpilz jasonpilz self-assigned this Sep 9, 2024
@jasonpilz jasonpilz requested a review from dadgar as a code owner September 9, 2024 17:21
@jasonpilz jasonpilz added the pr/no-changelog Disable enforcement of changelog entry label Sep 9, 2024
@jasonpilz jasonpilz mentioned this pull request Sep 9, 2024
Merged
2 tasks
dadgar
dadgar approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@dadgar dadgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see the errors, those teams probably need updated access on the repo.

@jasonpilz jasonpilz closed this Oct 10, 2024
@jasonpilz jasonpilz deleted the jasonpilz/update-ownership branch October 10, 2024 21:09
@jasonpilz
Copy link
Member Author

Yep, thanks. Got the permissions sorted. Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadgar dadgar dadgar approved these changes

@pierluc-codes pierluc-codes pierluc-codes approved these changes

Assignees

@jasonpilz jasonpilz

Labels
pr/no-changelog Disable enforcement of changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonpilz @pierluc-codes @dadgar