New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

license: add LICENSE file to release zip and docker image #159

Merged

dadgar merged 1 commit into main from license

Sep 10, 2024

Collaborator

dadgar commented Sep 10, 2024 •

edited

Loading

Changes proposed in this PR:

Adding LICENSE file to release zip/docker image

How I've tested this PR:

Build the binaries and download the zips / docker image and verified: https://github.com/hashicorp/hcp/actions/runs/10797537783

How I expect reviewers to test this PR:

Compare against suggestions:
https://hermes.hashicorp.services/document/1axPAhaN2xk70-GwyqRznWx6Voxetc_FLVa-zM8Kza1w
https://github.com/hashicorp/crt-core-helloworld/pull/172/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R43

Checklist:

Tests added if applicable
CHANGELOG entry added or label 'pr/no-changelog' added to PR

Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
in authoring a changelog entry, and commit the resulting file, which should
have a name matching your PR number. Entries should use imperative present
tense (e.g. Add support for...)


          license: add LICENSE file to release zip and docker image

da12cf6

dadgar added the pr/no-changelog label

dadgar marked this pull request as ready for review

September 10, 2024 17:37

dadgar requested a review from pierluc-codes

September 10, 2024 17:37

pierluc-codes approved these changes

View reviewed changes

dadgar merged commit 680b218 into main

24 of 33 checks passed

dadgar deleted the license branch

September 10, 2024 17:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-changelog