Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dockerfile curl install from edge #180

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Remove dockerfile curl install from edge #180

merged 1 commit into from
Oct 10, 2024

Conversation

jasonpilz
Copy link
Member

@jasonpilz jasonpilz commented Oct 10, 2024 •
edited
Loading

Changes proposed in this PR:

  • Dockerfile curl install was terminating with an exception when installing from edge.
  • Revert to installing curl without specifying the version now that the previous CVE has been addressed.

How I've tested this PR:

make docker/dev

How I expect reviewers to test this PR:

make docker/dev or view the build action.

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@jasonpilz jasonpilz self-assigned this Oct 10, 2024
@jasonpilz jasonpilz added the pr/no-changelog Disable enforcement of changelog entry label Oct 10, 2024
@jasonpilz jasonpilz marked this pull request as ready for review October 10, 2024 21:21
@jasonpilz jasonpilz requested review from dadgar and a team as code owners October 10, 2024 21:21
@jasonpilz jasonpilz merged commit 782806d into main Oct 10, 2024
22 of 23 checks passed
@jasonpilz jasonpilz deleted the jasonpilz/CRT-build-bug branch October 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meirish meirish meirish approved these changes

@dadgar dadgar Awaiting requested review from dadgar

Assignees

@jasonpilz jasonpilz

Labels
pr/no-changelog Disable enforcement of changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonpilz @meirish