Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: heimdall owner #186

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: heimdall owner #186

merged 1 commit into from
Oct 31, 2024

Conversation

pierluc-codes
Copy link
Contributor

Changes proposed in this PR:

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@pierluc-codes pierluc-codes added the pr/no-changelog Disable enforcement of changelog entry label Oct 30, 2024
@pierluc-codes pierluc-codes marked this pull request as ready for review October 30, 2024 20:28
@pierluc-codes pierluc-codes requested review from dadgar and a team as code owners October 30, 2024 20:28
@pierluc-codes pierluc-codes merged commit cc92389 into main Oct 31, 2024
6 of 7 checks passed
@pierluc-codes pierluc-codes deleted the pierluc-codes/fix-owner branch October 31, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashi-derek hashi-derek hashi-derek approved these changes

@jasonpilz jasonpilz jasonpilz approved these changes

@dadgar dadgar Awaiting requested review from dadgar

Assignees
No one assigned
Labels
pr/no-changelog Disable enforcement of changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierluc-codes @jasonpilz @hashi-derek