-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HV-1702 create postgres rotating secret #192
Conversation
Could you add a test case for postgres? Also, when I try to create a config interactively:
|
Co-authored-by: Nick Cabatoff <[email protected]>
"integration_name": "", | ||
"rotation_policy_name": "", | ||
"postgres_params": map[string]any{ | ||
"usernames": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this allow multiple usernames to be specified?
Context: opts.Ctx, | ||
}, mock.Anything).Return(&preview_secret_service.UpdatePostgresRotatingSecretOK{ | ||
Payload: &preview_models.Secrets20231128UpdatePostgresRotatingSecretResponse{ | ||
Config: &preview_models.Secrets20231128PostgresRotatingSecretConfig{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't PostgresParams returned here too?
Co-authored-by: Anton Averchenkov <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]>
Changes proposed in this PR:
Adds support for creating postgres rotating secrets.
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: