Create Waypoint resources with module ID #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
force-pushed
the
WAYP-3107
branch
from
8bb0382 to
eaf3830
Compare
paladin-devops
changed the title
BREAKING CHANGE: The no-code module ID is required when creating a template or add-on definition for Waypoint.
paladin-devops
force-pushed
the
WAYP-3107
branch
from
474f68b to
9f230cf
Compare
HenryEstberg
approved these changes
Dec 13, 2024
| @@ -135,6 +136,15 @@ $ hcp waypoint add-ons definitions create -n=my-add-on-definition \ | |||
| "when the execution mode is set to 'agent'.", | |||
| Value: flagvalue.Simple("", &opts.TerraformAgentPoolID), | |||
| }, | |||
| { | |||
| Name: "tf-no-code-module-id", | |||
There was a problem hiding this comment.
Totally nonblocking and more of just a general observation about the Waypoint CLI commands:
With flags like this that have longer names, typing them out can be fairly frustrating in my experience when you have to enter a bunch of them. To alleviate this, I think a useful pattern for us to adopt would be adding many more "shorthand" options to these flags.
Not necessarily something you have to do here as it might be useful to do en masse if we go in this direction, but reading your PR reminded me of it.
There was a problem hiding this comment.
I agree that having shorthand flags for these longer-named flags would be nice shortcuts for users who frequent the CLI!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The no-code module ID is required when creating a template or add-on definition for Waypoint.
🛠️ Description
🔗 Additional Link
🏗️ Local Testing
👍 Checklist