Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do initial work on adding the waypoint agent #2

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Do initial work on adding the waypoint agent #2

merged 2 commits into from
Feb 28, 2024

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented Feb 7, 2024

No description provided.

@evanphx evanphx requested review from dadgar and teresamychu February 7, 2024 18:31
dadgar
dadgar requested changes Feb 8, 2024
View reviewed changes
internal/commands/hcp/hcp.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/agent.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/agent.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/group.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/group.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/queue.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/queue.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/run.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/run.go Outdated Show resolved Hide resolved
internal/commands/waypoint/waypoint.go Outdated Show resolved Hide resolved
@evanphx evanphx requested review from dadgar and briancain February 28, 2024 00:24
dadgar
dadgar reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@dadgar dadgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review anything in internal/pkg/waypoint-agent/*. Will leave that to team reviews

internal/commands/waypoint/agent/group_create.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/group_create.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/group_delete.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/group_list.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/queue.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/queue.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/run.go Outdated Show resolved Hide resolved
internal/commands/waypoint/agent/group_create_test.go Outdated Show resolved Hide resolved
internal/pkg/cmd/command_internal.go Outdated Show resolved Hide resolved
internal/pkg/waypoint-agent/compound_operation.go Outdated Show resolved Hide resolved
evanphx
evanphx commented Feb 28, 2024
View reviewed changes
internal/commands/waypoint/agent/group_list.go Outdated
ValueFormat: "{{ .Description }}",
},
}
return opts.Output.Show(list.Payload.Groups, "name", "description")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadgar Since we're doing this a lot already, I wrote a quick way to infer the fields from the struct value and use it here.

dadgar
dadgar reviewed Feb 28, 2024
View reviewed changes
internal/pkg/format/output.go Outdated Show resolved Hide resolved
internal/pkg/format/output.go Outdated Show resolved Hide resolved
@evanphx evanphx requested a review from dadgar February 28, 2024 21:14
dadgar
dadgar reviewed Feb 28, 2024
View reviewed changes
internal/pkg/format/output.go Outdated Show resolved Hide resolved
internal/pkg/format/output.go Outdated Show resolved Hide resolved
@evanphx evanphx force-pushed the f-waypoint-agent branch 3 times, most recently from e5377a2 to 5e83e2c Compare February 28, 2024 23:37
dadgar
dadgar approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@dadgar dadgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! For transparency I didn't review the agent code in case you want a set of Waypoint eyes there.

Thanks for the improvements to the Formatter!

internal/pkg/format/output.go Show resolved Hide resolved
@evanphx evanphx merged commit 95e54e4 into main Feb 28, 2024
2 checks passed
@evanphx evanphx deleted the f-waypoint-agent branch February 28, 2024 23:47
@evanphx evanphx restored the f-waypoint-agent branch February 29, 2024 00:42
@dadgar dadgar deleted the f-waypoint-agent branch March 8, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadgar dadgar dadgar approved these changes

@teresamychu teresamychu Awaiting requested review from teresamychu

@briancain briancain Awaiting requested review from briancain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanphx @briancain @dadgar