Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to create a postgres integration should not be labelled as a mongodb error #203

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Failure to create a postgres integration should not be labelled as a mongodb error #203

merged 2 commits into from
Dec 10, 2024

Conversation

ncabatoff
Copy link
Contributor

🛠️ Description

🔗 Additional Link

🏗️ Local Testing

👍 Checklist

  • The PR has a descriptive title.
  • Input validation updated
  • Unit tests updated
  • Documentation updated
  • Major architecture changes have a corresponding RFC
  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@ncabatoff ncabatoff requested a review from a team as a code owner December 10, 2024 19:51
dhuckins
dhuckins previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@dhuckins dhuckins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ncabatoff ncabatoff requested a review from dhuckins December 10, 2024 20:34
@ncabatoff ncabatoff merged commit c83f079 into main Dec 10, 2024
6 checks passed
@ncabatoff ncabatoff deleted the nc/fix-postgres-error-sring branch December 10, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuckins dhuckins dhuckins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncabatoff @dhuckins