Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pagination on list apps for profile init #205

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mercedesbh
Copy link
Contributor

@mercedesbh mercedesbh commented Dec 18, 2024

🛠️ Description

A customer reported that they were restricted to only the first 10 apps (while the have about 300 of them total) when trying to select a HVS app for their profile hcp profile init --vault-secrets. This PR adds pagination support to the ListApps call.

🏗️ Local Testing

  1. Checkout this branch
  2. Run make go/build
  3. Ensure you have at least 11 HVS apps created
  4. Run ./bin/hcp profile init --vault-secrets and ensure all of your apps are listed

I have 12 HVS apps created total.

Before pagination (only 10 shown):
Screenshot 2024-12-18 at 2 24 35 PM

After pagination (all 12 shown):
Screenshot 2024-12-18 at 2 20 46 PM

👍 Checklist

  • The PR has a descriptive title.
  • Input validation updated
  • Unit tests updated
  • Documentation updated
  • Major architecture changes have a corresponding RFC
  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@mercedesbh mercedesbh marked this pull request as ready for review December 18, 2024 20:30
@mercedesbh mercedesbh requested a review from a team December 20, 2024 20:19
Copy link

@rodrigo-hcp rodrigo-hcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants