Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds HVS secrets import command #206

Open
wants to merge 3 commits into
base: release-HVS-import-secrets
Choose a base branch
from

Conversation

mercedesbh
Copy link
Contributor

πŸ› οΈ Description

This change:

  • Adds the cmd.Command configuration for import
  • Adds the import commad to secrets.go
  • Adds the test file for import

πŸ”— Additional Link

https://hashicorp.atlassian.net/browse/HV-3134

πŸ—οΈ Local Testing

  1. Checkout this branch
  2. Run make go/build
  3. Run ./bin/hcp vs secrets import --help and ensure all of your apps are listed
Screenshot 2024-12-20 at 5 05 27β€―PM

πŸ‘ Checklist

  • The PR has a descriptive title.
  • Input validation updated
  • Unit tests updated
  • Documentation updated
  • Major architecture changes have a corresponding RFC
  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@mercedesbh mercedesbh changed the base branch from main to release-HVS-import-secrets December 20, 2024 23:09
@mercedesbh mercedesbh marked this pull request as ready for review December 20, 2024 23:09
@mercedesbh mercedesbh requested a review from a team as a code owner December 20, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant