Add new API client for Waypoint. #208
Conversation
paladin-devops
force-pushed
the
WAYP-3243-add-new-client
branch
2 times, most recently
from
f0e1d89 to
60a2889
Compare
The new client will be used to communicate with HCP Waypoint.
paladin-devops
force-pushed
the
WAYP-3243-add-new-client
branch
from
60a2889 to
b17f4dd
Compare
* feat: Update Waypoint TFCConfig commands to use new client. * feat: Update Waypoint templates commands to use new client. * feat: Update Waypoint add-on definition commands to use new client. * feat: Update Waypoint application commands to use new client. * feat: Update Waypoint add-on commands to use new client.
|
@paladin-devops is it important? |
|
@pierluc-codes yes, @jfreda is working on the other part of this. |
|
This PR is more than 2 weeks old. Please remove the stale label, update, or comment if this PR is still valid and relevant, otherwise it will be closed in 7 days. |
* Update Waypoint actions commands to use new service * Update Waypoint agent commands to use new service * Looks like we can remove the NamespaceID now
paladin-devops
changed the title
go.mod
Outdated
| @@ -12,7 +12,7 @@ require ( | |||
| github.com/hashicorp/go-multierror v1.1.1 | |||
| github.com/hashicorp/go-version v1.7.0 | |||
| github.com/hashicorp/hcl/v2 v2.23.0 | |||
| github.com/hashicorp/hcp-sdk-go v0.131.0 | |||
| github.com/hashicorp/hcp-sdk-go v0.131.1-0.20250115174642-56cccc8d9986 | |||
There was a problem hiding this comment.
Make this a full version please!
| Profile: ctx.Profile, | ||
| IO: ctx.IO, | ||
| Output: ctx.Output, | ||
| WS: waypoint_service.New(ctx.HCP, nil), |
There was a problem hiding this comment.
Should this be still creating the WS based on the 20230818 service? Do we still need anything related to the 2023 service here at all?
There was a problem hiding this comment.
That was kept there while the downstream PRs were in-flight so that hcp would still compile (if you removed that and things were still using it, you'd have to update all usages right away). Now that they're merged here, I'll remove this!
There was a problem hiding this comment.
Updated! e2639e1
| @@ -1,6 +1,8 @@ | |||
| module github.com/hashicorp/hcp | |||
|
|
|||
| go 1.22.2 | |||
| go 1.23 | |||
There was a problem hiding this comment.
@pierluc-codes should we stay pinned on Go v1.22.2? If so I will roll this back.
The new client will be used to communicate with HCP Waypoint.
🛠️ Description
🔗 Additional Link
🏗️ Local Testing
👍 Checklist