Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displayer helper #22

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Displayer helper #22

merged 3 commits into from
Feb 27, 2024

Conversation

dadgar
Copy link
Collaborator

@dadgar dadgar commented Feb 26, 2024 •
edited
Loading

Exploration for adding a helper that builds a displayer.

Fixes #16

@dadgar dadgar requested a review from briancain February 26, 2024 23:23
@dadgar dadgar marked this pull request as ready for review February 26, 2024 23:54
@dadgar dadgar changed the title POC: Displayer helper Displayer helper Feb 27, 2024
briancain
briancain approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I haven't tried it, but assuming the test is good, works for me 👍🏻

@dadgar
Copy link
Collaborator Author

dadgar commented Feb 27, 2024

Yeah of course! Thanks for spotting the boiler plate, this is better!

@dadgar dadgar merged commit 7f3b4b3 into main Feb 27, 2024
2 checks passed
@dadgar dadgar deleted the f-format-helper branch February 27, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add helpers for creating a format.Displayer
2 participants
@dadgar @briancain