Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Add action-config update CLI #25

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

briancain
Copy link
Member

This commit adds an update sub-command so users can update action
configs on the CLI as well as create them.

Fixes WAYP-2385

This commit adds an update sub-command so users can update action
configs on the CLI as well as create them.
Copy link
Contributor

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved, with some suggestions about using Show now!

Comment on lines 10 to 14
actionConfigFields = []format.Field{
format.NewField("Name", "{{ .Name }}"),
format.NewField("ID", "{{ .ID }}"),
format.NewField("Description", "{{ .Description }}"),
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Output.Show() for this instead now, that's merged.

internal/commands/waypoint/actionconfig/list.go Outdated Show resolved Hide resolved
internal/commands/waypoint/actionconfig/read.go Outdated Show resolved Hide resolved
internal/commands/waypoint/actionconfig/update.go Outdated Show resolved Hide resolved
internal/commands/waypoint/actionconfig/update.go Outdated Show resolved Hide resolved
@briancain briancain merged commit 0c92144 into main Mar 4, 2024
2 checks passed
@briancain briancain deleted the actions/add-update-cmd branch March 4, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants