Add initial TFC Config Set Command #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a template to preserve new lines for a subset of a template rather than the whole template.
briancain
reviewed
Feb 7, 2024
This repo will probably want to be outfitted with hcp-checks, which includes a linter.
evanphx
suggested changes
Feb 8, 2024
dadgar
requested changes
Feb 8, 2024
…a-repo GH: Add basic GH Actions workflow for code quality
catsby
reviewed
Feb 9, 2024
teresamychu
force-pushed
the
add_tfc_config_set_cmd
branch
3 times, most recently
from
fa6e984 to
c3cb38e
Compare
dadgar
reviewed
Feb 12, 2024
dadgar
reviewed
Feb 12, 2024
briancain
reviewed
Feb 12, 2024
briancain
approved these changes
Feb 13, 2024
dadgar
requested changes
Feb 13, 2024
Co-authored-by: Alex Dadgar <[email protected]>
Co-authored-by: Alex Dadgar <[email protected]>
Co-authored-by: Alex Dadgar <[email protected]>
Co-authored-by: Brian Cain <[email protected]>
Co-authored-by: Alex Dadgar <[email protected]>
Co-authored-by: Brian Cain <[email protected]>
Co-authored-by: Brian Cain <[email protected]>
Co-authored-by: Alex Dadgar <[email protected]>
Co-authored-by: Alex Dadgar <[email protected]>
|
Rebase is being weird. Fixing it now. |
teresamychu
force-pushed
the
add_tfc_config_set_cmd
branch
from
7662a06 to
1b9cf6d
Compare
dadgar
reviewed
Feb 21, 2024
internal/commands/waypoint/bin/hcp
Outdated
There was a problem hiding this comment.
You accidentally added the binary
There was a problem hiding this comment.
Can you please rewrite the git history to not include this.
There was a problem hiding this comment.
WHOOPS. WILL FIX. Thanks!
dadgar
reviewed
Feb 21, 2024
| @@ -0,0 +1,122 @@ | |||
| package tfcconfig | |||
There was a problem hiding this comment.
Please consider adding unit tests
dadgar
approved these changes
Feb 22, 2024
teresamychu
force-pushed
the
add_tfc_config_set_cmd
branch
from
45a8e00 to
423ce2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Initial TFC Config Set Command for Waypoint.
Will probably have to do some conflict resolving once Evan merges his PR.