Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcp waypoint add-ons definitions #44

Merged
merged 14 commits into from
Mar 28, 2024
Merged

Conversation

paladin-devops
Copy link
Contributor

@paladin-devops paladin-devops commented Mar 25, 2024

Changes proposed in this PR:

Add a CLI command for managing HCP Waypoint add-on definitions.

Closes WAYP-2344.

How I've tested this PR:

Using the examples in the help text of each new command to manually manage HCP Waypoint add-on definitions. I have also added unit tests to test that the flags are set, where applicable.

How I expect reviewers to test this PR:

Using the examples in the help text of each new command to manually manage HCP Waypoint add-on definitions.

Output of affected commands:

TODO

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@paladin-devops paladin-devops self-assigned this Mar 25, 2024
@paladin-devops paladin-devops force-pushed the WAYP-2344-add-on-definitions branch from 0597a44 to 3131ebd Compare March 25, 2024 17:00
@paladin-devops paladin-devops marked this pull request as ready for review March 25, 2024 17:02
@paladin-devops paladin-devops requested review from a team and dadgar as code owners March 25, 2024 17:02
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@paladin-devops paladin-devops merged commit caf8075 into main Mar 28, 2024
7 checks passed
@paladin-devops paladin-devops deleted the WAYP-2344-add-on-definitions branch March 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants