Fix panic displaying invoked command #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the command recieves an error because the authentication token expired and wasn't able to be refreshed, we display a help error informing the user to logout, login, and re-run the command. A panic was occuring if the previous command had escaped quoted inputs, since the string was being directly added to a template that itself had quotes. This was causing the template string to become invalid, and then rendering the template would error. This commit causes the command to be properly escaped before it is injected into the template.
dadgar
force-pushed
the
b-command-escaping
branch
from
4b02f9e to
f2b21ff
Compare
WenInCode
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
When the command recieves an error because the authentication token expired and wasn't able to be refreshed, we display a help error informing the user to logout, login, and re-run the command.
A panic was occuring if the previous command had escaped quoted inputs, since the string was being directly added to a template that itself had quotes. This was causing the template string to become invalid, and then rendering the template would error.
This commit causes the command to be properly escaped before it is injected into the template.
How I've tested this PR:
Added a test that failed before the change, and now works. Also caused the new error message to be displayed for every command being run to verify no more panics.
How I expect reviewers to test this PR:
Does the code logic look correct.
Checklist: